fix: Add missing 'typing-extensions' dependency #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skim0119
requested review from
skim0119
and removed request for
armantekinalp
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## update-v1 #524 +/- ##
============================================
Coverage ? 95.19%
============================================
Files ? 48
Lines ? 3140
Branches ? 318
============================================
Hits ? 2989
Misses ? 104
Partials ? 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523
Description
This PR adds
typing-extensionsto the package dependencies list.Currently,
elastica/rod/cosserat_rod.pyimportsSelffromtyping_extensions, but the package is not listed in the installation requirements. This causes aModuleNotFoundErrorfor users installing PyElastica in fresh environments (specifically verified on Python 3.12).Changes
"typing-extensions"to thedependencieslist.